[PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

Lad, Prabhakar prabhakar.csengg at gmail.com
Wed Dec 20 13:15:09 UTC 2017


Hi Mauro,

Thanks for the patch.

On Tue, Dec 19, 2017 at 11:18 AM, Mauro Carvalho Chehab
<mchehab at s-opensource.com> wrote:
> The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
> struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
> match criteria requires just a device name.
>
> So, it doesn't make sense to enclose those into structs,
> as the criteria can go directly into the union.
>
> That makes easier to document it, as we don't need to document
> weird senseless structs.
>
> At drivers, this makes even clearer about the match criteria.
>
> Acked-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
> Acked-by: Benoit Parrot <bparrot at ti.com>
> Acked-by: Alexandre Belloni <alexandre.belloni at free-electrons.com>
> Acked-by: Sakari Ailus <sakari.ailus at linux.intel.com>
> Acked-by: Philipp Zabel <p.zabel at pengutronix.de>
> Signed-off-by: Mauro Carvalho Chehab <mchehab at s-opensource.com>
> ---
>  drivers/media/platform/am437x/am437x-vpfe.c    |  6 +++---

For above:

Acked-by: Lad, Prabhakar <prabhakar.csengg at gmail.com>

Cheers,
--Prabhakar Lad


More information about the devel mailing list