[PATCHv4] staging: pi433: pi433_if.c remove SET_CHECKED macro

Dan Carpenter dan.carpenter at oracle.com
Fri Dec 8 10:48:27 UTC 2017


On Fri, Dec 08, 2017 at 11:43:19AM +0100, Nguyen Phan Quang Minh wrote:
> The macro calls its argument -a function- twice, makes the calling
> function return prematurely -skipping resource cleanup code- and hurts
> understandability.
> 
> Signed-off-by: Nguyen Phan Quang Minh <minhnpq16 at gmail.com>

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>

regards,
dan carpenter



More information about the devel mailing list