[PATCH v2 00/11] Fix indentation and CamelCase issue in staging/pi433

Simon Sandström simon at nikanor.nu
Tue Dec 5 22:08:38 UTC 2017


These patches fixes a bunch of code style issues in staging/pi433. The first
patch fixes indentation in rf69_enum.h and the rest of the patches fixes
CamelCase issues and other minor issues in all of staging/pi433.

Changes in v2:
	- Instead of fixing CamelCase issue in enum data_mode, remove it
	  completely.

	- Split multiple functions of type
	  "rf69_set_x_enabled(dev, enum option_on_off)" to two functions:
	  "rf69_enable_x(dev)" and "rf69_disable_x(dev)".

	- Move enum option_on_off to pi433_if.h as it's now only used for
	  ioctl.

	- Fix issue where GPIOs and device not being deallocated in
	  pi433_probe() if SET_CHECKED fails.

- Simon

---

Simon Sandström (11):
  staging: pi433: Fix indentation in rf69_enum.h
  staging: pi433: Capitalize constant definitions
  staging: pi433: Rename variable in struct pi433_rx_cfg
  staging: pi433: Rename enum optionOnOff in rf69_enum.h
  staging: pi433: Rename enum modShaping in rf69_enum.h
  staging: pi433: Split rf69_set_crc_enabled into two functions
  staging: pi433: Split rf69_set_sync_enabled into two functions
  staging: pi433: Remove enum data_mode
  staging: pi433: Combine all rf69_set_amplifier_x()
  staging: pi433: Move enum option_on_off to pi433_if.h
  staging: pi433: Remove SET_CHECKED usage from pi433_probe

 drivers/staging/pi433/pi433_if.c       | 135 ++++++++++++++-------
 drivers/staging/pi433/pi433_if.h       |  25 ++--
 drivers/staging/pi433/rf69.c           | 113 +++++-------------
 drivers/staging/pi433/rf69.h           |  15 +--
 drivers/staging/pi433/rf69_enum.h      | 210 ++++++++++++++++-----------------
 drivers/staging/pi433/rf69_registers.h |  44 +++----
 6 files changed, 265 insertions(+), 277 deletions(-)

-- 
2.11.0



More information about the devel mailing list