[PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.
Dan Carpenter
dan.carpenter at oracle.com
Sun Dec 3 05:39:21 UTC 2017
On Sat, Dec 02, 2017 at 08:41:48PM +0000, Jeremy Sowden wrote:
> On 2017-12-02, at 10:35:06 +0000, Jeremy Sowden wrote:
> > On 2017-12-02, at 13:20:09 +0300, Dan Carpenter wrote:
> > > On Fri, Dec 01, 2017 at 05:19:37PM +0000, Jeremy Sowden wrote:
> > > > -#define DEFAULT_PIPE_INFO \
> > > > -{ \
> > > > - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* output_info */ \
> > > > - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* vf_output_info */ \
> > > > - IA_CSS_BINARY_DEFAULT_FRAME_INFO, /* raw_output_info */ \
> > > > - { 0, 0}, /* output system in res */ \
> > > > - DEFAULT_SHADING_INFO, /* shading_info */ \
> > > > - DEFAULT_GRID_INFO, /* grid_info */ \
> > > > - 0 /* num_invalid_frames */ \
> > > > -}
> > > > +#define DEFAULT_PIPE_INFO ( \
> > >
> > > Why does this have a ( now? That can't compile can it??
> >
> > It does.
>
> That was a bit terse: the macros expand to compound-literals, so
> putting parens around them is no different from:
>
> #define THREE (3)
Yeah. Thanks. I figured it out despite the terseness... I try review
as fast as I can, so it means you get the stream of conciousness output
that often has mistakes. Sorry about that.
regards,
dan carpenter
More information about the devel
mailing list