[PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations

Greg KH gregkh at linuxfoundation.org
Sat Dec 2 15:55:49 UTC 2017


On Sat, Dec 02, 2017 at 05:14:08PM +0200, Marcus Wolf wrote:
> The define FIFO_SIZE was moved to rf69_registers.h. Although it is not a register,
> it is a value, that is given by hardware (like the registers).
> 
> The define FIFO_THRESHOLD was moved to pi433_if.c, since it is a value, that is
> freely choosen by the interface implementation. The better the response time of
> the driver, the lower threshold can be set.

Shouldn't this be two separate patches?

Remember, each patch just does one thing.

thanks,

greg k-h


More information about the devel mailing list