[PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()

Marcus Wolf linux at wolf-entwicklungen.de
Sat Dec 2 09:58:12 UTC 2017


From: root <root at Laptop-Wolf>

Defines used in cases contain already shifted bits, so currentValue must not be shifted.
Signed-off-by: Marcus Wolf <linux at wolf-entwicklungen.de>
---
 drivers/staging/pi433/rf69.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a215..12c9df9 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -102,7 +102,7 @@ enum modulation rf69_get_modulation(struct spi_device *spi)
 
 	currentValue = READ_REG(REG_DATAMODUL);
 
-	switch (currentValue & MASK_DATAMODUL_MODULATION_TYPE >> 3) { // TODO improvement: change 3 to define
+	switch (currentValue & MASK_DATAMODUL_MODULATION_TYPE) {
 	case DATAMODUL_MODULATION_TYPE_OOK: return OOK;
 	case DATAMODUL_MODULATION_TYPE_FSK: return FSK;
 	default:			    return undefined;
-- 
1.7.10.4



More information about the devel mailing list