[PATCH v2] staging: most: hdm_usb: Driver registration with module_usb_driver

Andrey Shvetsov andrey.shvetsov at k2l.de
Tue Aug 29 10:27:12 UTC 2017


On Tue, Aug 29, 2017 at 11:44:37AM +0300, Alex Briskin wrote:
> A change was made to the commit message itself.
> In V1, as pointed out by Andy, I left module_driver instead of
> module_usb_driver in the commit message.
Dont't forget to fix the subject.  "Driver registration ..." is not
compliant to the rules:

[Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to
do frotz”, as if you are giving orders to the codebase to change its
behaviour.](https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#describe-your-changes)

> 
> On Aug 29, 2017 9:25 AM, "Greg KH" <gregkh at linuxfoundation.org> wrote:
> 
> On Mon, Aug 28, 2017 at 08:40:16PM +0300, Alex Briskin wrote:
> > Register with module_usb_driver macro instead of module_init/module_exit.
> >
> > Signed-off-by: Alex Briskin <br.shurik at gmail.com>
> > ---
> >  drivers/staging/most/hdm-usb/hdm_usb.c | 20 +-------------------
> >  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> What changed from v1?  Always put that below the --- line so we know
> what is going on.
> 
> Also, isn't this patch already applied in my tree?  Why resend it?
> 
> thanks,
> 
> greg k-h


More information about the devel mailing list