[PATCHv2] hv_set_ifconfig.sh double check before setting ip

Haiyang Zhang haiyangz at microsoft.com
Mon Aug 28 15:56:44 UTC 2017



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Monday, August 28, 2017 11:16 AM
> To: Eduardo Otubo <otubo at redhat.com>
> Cc: linux-kernel at vger.kernel.org; devel at linuxdriverproject.org; Haiyang
> Zhang <haiyangz at microsoft.com>; Stephen Hemminger
> <sthemmin at microsoft.com>; David Miller <davem at davemloft.net>
> Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip
> 
> On Mon, 28 Aug 2017 12:01:21 +0200
> Eduardo Otubo <otubo at redhat.com> wrote:
> 
> > v2: The script is now a little bit safer so it doesn't conflicts with
> > network daemon trying to set configurations at the same time.
> >
> > This patch fixes the behavior of the hv_set_ifconfig script when
> setting
> > the interface ip. Sometimes the interface has already been configured
> by
> > network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
> > exists error"; in order to avoid this error this patch makes sure
> double
> > checks the interface before trying anything.
> >
> > Signed-off-by: Eduardo Otubo <otubo at redhat.com>
> 
> Adding new dependency on systemd is not going to make this script
> even less useful.  I wonder why the script still exists at all? Most of
> the
> Linux distro's can already setup HV networking without it.
> 

This script is used by a host to inject IP into guests. KY knows more 
details about it.




More information about the devel mailing list