[PATCH] staging: greybus: light: fix memory leak in v4l2 register

Rui Miguel Silva rmfrfs at gmail.com
Wed Aug 9 09:57:43 UTC 2017


Hi Sakari,
On Wed, Aug 09, 2017 at 12:14:17PM +0300, Sakari Ailus wrote:
> Hi Rui and Johan,
>
> On 08/02/17 19:52, Rui Miguel Silva wrote:
> > We are allocating memory for the v4l2 flash configuration structure and
> > leak it in the normal path. Just use the stack for this as we do not
> > use it outside of this function.
> >
> > Fixes: 2870b52bae4c ("greybus: lights: add lights implementation")
> > Reported-by: Sakari Ailus <sakari.ailus at linux.intel.com>
> > Signed-off-by: Rui Miguel Silva <rmfrfs at gmail.com>
>
> My apologies for missing sending the original patch to the appropriate
> recipients the first time.

No problem, this kind of things happens.

>
> Could I take this through the mediatree?

For me that's fine, since you need this for your other patch.
please add the reviewed-by tag from Viresh.

> The second patch in the original set now depends on this one.
> I'll cc you the second patch as well, it will need updates.

Thanks, I will review the changes to greybus light then.

---
Cheers,
	Rui


More information about the devel mailing list