[PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

Dan Carpenter dan.carpenter at oracle.com
Wed Aug 2 08:26:23 UTC 2017


The subject is too vague.  The patch prefix isn't right.  Do
`git log --oneline drivers/staging/pi433/` to see what other people are
doing:

99859541a92d staging: pi433: use div_u64 for 64-bit division
056eeda2f9e6 staging: pi433: Style fix - align block comments
775f6ab013d3 staging: pi433: Make functions rf69_set_bandwidth_intern static
c7d42f37087d Staging: pi433: check error after kthread_run()
7de77a3917e3 Staging: pi433: declare functions static
0119a48b69fe staging: pi433: depends on SPI

So the subject should be something like:

[PATCH] staging: pi433: rename camel case variables

Also there was no patch description and that's required.

regards,
dan carpenter



More information about the devel mailing list