[PATCH] staging: comedi: use memdup_user

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sat Apr 29 05:17:28 UTC 2017


On Fri, Apr 28, 2017 at 06:53:32PM -0700, Joe Perches wrote:
> On Sat, 2017-04-29 at 09:45 +0800, Geliang Tang wrote:
> > Use memdup_user() helper instead of open-coding to simplify the code.
> 
> While I doubt this is a problem, this loses
> the multiplication overflow check for
> sizeof(*insns) * insnlist.n_isns

Yes it is a problem, we need that check.

thanks,

greg k-h


More information about the devel mailing list