[PATCH 19/19] staging: ks7010: rename ks_hostif to hostif

Tobin C. Harding me at tobin.cc
Wed Apr 26 00:55:24 UTC 2017


Driver uses non-uniform file names. Both in respect to itself and in
respect to other SDIO drivers. If we name files in a similar fashion
to in-tree SDIO drivers then we are following the principle of least
surprise.

Looking at in-tree SDIO drivers, 'sdio' is the name of choice for SDIO
code.

Rename ks7010_sdio.c to sdio.c
Rename ks7010_sdio.h to sdio.h

Signed-off-by: Tobin C. Harding <me at tobin.cc>
---
 drivers/staging/ks7010/Makefile                  | 2 +-
 drivers/staging/ks7010/ks_wlan.h                 | 2 +-
 drivers/staging/ks7010/{ks7010_sdio.c => sdio.c} | 2 +-
 drivers/staging/ks7010/{ks7010_sdio.h => sdio.h} | 0
 4 files changed, 3 insertions(+), 3 deletions(-)
 rename drivers/staging/ks7010/{ks7010_sdio.c => sdio.c} (99%)
 rename drivers/staging/ks7010/{ks7010_sdio.h => sdio.h} (100%)

diff --git a/drivers/staging/ks7010/Makefile b/drivers/staging/ks7010/Makefile
index 23cf95a..cb89a62 100644
--- a/drivers/staging/ks7010/Makefile
+++ b/drivers/staging/ks7010/Makefile
@@ -1,4 +1,4 @@
 obj-$(CONFIG_KS7010) += ks7010.o
 
 ccflags-y 	     += -DKS_WLAN_DEBUG=0
-ks7010-y	     := michael_mic.o hostif.o ks_wlan_net.o ks7010_sdio.o
+ks7010-y	     := michael_mic.o hostif.o ks_wlan_net.o sdio.o
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index cd4f56d..6881dd0 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -32,7 +32,7 @@
 
 #include <linux/io.h>
 
-#include "ks7010_sdio.h"
+#include "sdio.h"
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/sdio.c
similarity index 99%
rename from drivers/staging/ks7010/ks7010_sdio.c
rename to drivers/staging/ks7010/sdio.c
index 6c10e3d..2f21c93 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/sdio.c
@@ -19,7 +19,7 @@
 #include "ks_wlan.h"
 #include "ks_wlan_ioctl.h"
 #include "hostif.h"
-#include "ks7010_sdio.h"
+#include "sdio.h"
 
 #define KS7010_FUNC_NUM 1
 #define KS7010_IO_BLOCK_SIZE 512
diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/sdio.h
similarity index 100%
rename from drivers/staging/ks7010/ks7010_sdio.h
rename to drivers/staging/ks7010/sdio.h
-- 
2.7.4



More information about the devel mailing list