[PATCH 07/18] staging: ks7010: clean up SDIO header comments

Greg Kroah-Hartman gregkh at linuxfoundation.org
Fri Apr 14 08:22:59 UTC 2017


On Wed, Apr 12, 2017 at 09:56:52AM +1000, Tobin C. Harding wrote:
> SDIO header file does not use kernel doc format struct
> comments. Adding them aids readability and enables documentation to be
> built from the source code. Other comments may be tidied up as we do this.
> 
> Add kernel format struct comments. Tidy up comments.
> 
> Signed-off-by: Tobin C. Harding <me at tobin.cc>
> ---
>  drivers/staging/ks7010/ks7010_sdio.h | 56 +++++++++++++++++++++++++++---------
>  1 file changed, 42 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h
> index b9d5a41..63fbd2d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.h
> +++ b/drivers/staging/ks7010/ks7010_sdio.h
> @@ -82,8 +82,6 @@ enum gen_com_reg_b {
>  };
>  
>  /* Wakeup Register */
> -/* #define WAKEUP			0x008104 */
> -/* #define WAKEUP_REQ		0x00 */
>  #define WAKEUP			0x008018
>  #define WAKEUP_REQ		0x5a
>  
> @@ -93,9 +91,6 @@ enum gen_com_reg_b {
>  
>  #define KS7010_IRAM_ADDRESS	0x06000000
>  
> -/*
> - * struct define
> - */
>  struct hw_info_t {
>  	struct ks_sdio_card *sdio_card;
>  	struct workqueue_struct *ks7010sdio_wq;
> @@ -108,38 +103,71 @@ struct ks_sdio_card {
>  	struct ks_wlan_private *priv;
>  };
>  
> -/* Tx Device struct */
> +/*
> + * Tx Queue
> + */
> +

Why a blank line?

Anyway, patch doesn't apply as I didn't take earlier patches.  I've
stopped here, please fix up and resend the series.

thanks,

greg k-h


More information about the devel mailing list