[PATCH] scsi: storvsc: remove return at end of void function

KY Srinivasan kys at microsoft.com
Thu Apr 13 23:28:54 UTC 2017



> -----Original Message-----
> From: Miguel Bernal Marin [mailto:miguel.bernal.marin at linux.intel.com]
> Sent: Thursday, March 16, 2017 12:00 AM
> To: KY Srinivasan <kys at microsoft.com>; Martin K. Petersen
> <martin.petersen at oracle.com>
> Cc: linux-kernel at vger.kernel.org; linux-scsi at vger.kernel.org;
> devel at linuxdriverproject.org; Haiyang Zhang <haiyangz at microsoft.com>;
> Stephen Hemminger <sthemmin at microsoft.com>; James E.J. Bottomley
> <jejb at linux.vnet.ibm.com>
> Subject: [PATCH] scsi: storvsc: remove return at end of void function
> 
> storvsc_on_channel_callback is a void function and the return
> statement at the end is not useful.
> 
> Found with checkpatch.
> 
> Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin at linux.intel.com>

Reviewed-by:  K. Y. Srinivasan <kys at microsoft.com>

> ---
>  drivers/scsi/storvsc_drv.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3d70d1cf49a3..538f3e131275 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1191,8 +1191,6 @@ static void storvsc_on_channel_callback(void
> *context)
>  			break;
>  		}
>  	} while (1);
> -
> -	return;
>  }
> 
>  static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
> --
> 2.12.0



More information about the devel mailing list