[PATCH 17/25] staging: ks7010: simplify complex logical statment

Tobin C. Harding me at tobin.cc
Sun Apr 2 00:11:52 UTC 2017


On Sun, Apr 02, 2017 at 01:29:00AM +0800, kbuild test robot wrote:
> Hi Tobin,
> 
> [auto build test WARNING on staging/staging-testing]
> [also build test WARNING on next-20170331]
> [cannot apply to v4.11-rc4]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Tobin-C-Harding/staging-ks7010-checkpatch-clean-up/20170401-235953
> config: mips-allyesconfig (attached as .config)
> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=mips 
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/staging//ks7010/ks_hostif.c: In function 'hostif_data_indication_wpa':
> >> drivers/staging//ks7010/ks_hostif.c:337:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
>      if (priv->wpa.pairwise_suite == IW_AUTH_CIPHER_TKIP && key->key_len);
>      ^~
>    drivers/staging//ks7010/ks_hostif.c:338:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
>       return 0;
>       ^~~~~~

warning correctly indicated a bug introduced by this patch. I was
unable, however, to reproduce this warning locally. Why did the
compiler not throw this warning when invoked with the following
command (previous build files removed prior);

make -j9 EXTRA-CFLAGS=-W M=drivers/staging/ks7010

thanks,
Tobin


More information about the devel mailing list