[PATCH 2/3] staging: greybus: light: fix attributes allocation
Rui Miguel Silva
rmfrfs at gmail.com
Fri Sep 30 17:24:06 UTC 2016
Fix allocation of attributes with the correct size, this also fix smatch
warning:
drivers/staging/greybus/light.c:293 channel_attr_groups_set()
warn: double check that we're allocating correct size: 8 vs 16
Signed-off-by: Rui Miguel Silva <rmfrfs at gmail.com>
---
drivers/staging/greybus/light.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index b2847fe..c610d55 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -290,7 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel,
return 0;
/* Set attributes based in the channel flags */
- channel->attrs = kcalloc(size + 1, sizeof(**channel->attrs),
+ channel->attrs = kcalloc(size + 1, sizeof(struct attribute *),
GFP_KERNEL);
if (!channel->attrs)
return -ENOMEM;
--
2.10.0
More information about the devel
mailing list