[PATCH v2 02/21] staging: unisys: visorbus_main.c remove unused pound defines

Greg KH gregkh at linuxfoundation.org
Fri Sep 2 12:50:42 UTC 2016


On Thu, Sep 01, 2016 at 03:14:54PM -0400, David Kershner wrote:
> From: Erik Arfvidson <erik.arfvidson at unisys.com>
> 
> This removes two unused pound defines in the visorbus_main.c
> file.
> 
> Signed-off-by: Erik Arfvidson <erik.arfvidson at unisys.com>
> Signed-off-by: David Kershner <david.kershner at unisys.com>
> Reported-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 293532f..a100c79 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -29,13 +29,10 @@
>  static int visorbus_forcematch;
>  static int visorbus_forcenomatch;
>  
> -#define SERIALLOOPBACKCHANADDR (100 * 1024 * 1024)
> -
>  /* Display string that is guaranteed to be no longer the 99 characters*/
>  #define LINESIZE 99
>  
>  #define CURRENT_FILE_PC VISOR_BUS_PC_visorbus_main_c
> -#define POLLJIFFIES_TESTWORK         100

I appreciate the credit, but I didn't point this issue out, nor all of
the other problems in this patchset (some, but not all).

I only reviewed one file, can you limit my credit to just that one file
to be correct please?

thanks,

greg k-h


More information about the devel mailing list