[PATCH 1/2] staging: ks7010: return on failure

Greg Kroah-Hartman gregkh at linuxfoundation.org
Thu Sep 1 15:53:19 UTC 2016

On Wed, Aug 24, 2016 at 12:07:35AM +0530, Sudip Mukherjee wrote:
> On failure we were jumping to error_out0 where we were trying
> sdio_release_host() but at this point of execution we still have not
> done sdio_claim_host() and as a result host->claimed can still be 0.
> And if host->claimed is 0 then WARN_ON(!host->claimed) will give
> a warning.
> Moreover, if it is still not claimed then mmc_host->claim_cnt will be 0
> and mmc_release_host() will do "if (--host->claim_cnt)" and thus the
> condition will become true.
> Lets just return the value on allocation failure instead of trying to
> release the host before claiming it.
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee at codethink.co.uk>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Please always cc: the maintainer of the driver when you send patches in.

Please fix that up and resend these 2 patches.


greg k-h

More information about the devel mailing list