[PATCH 4/6] gpio: cbc-presence: Add CBC presence detect as GPIO driver

Linus Walleij linus.walleij at linaro.org
Fri Oct 21 08:49:44 UTC 2016


On Fri, Oct 7, 2016 at 5:20 PM, Pantelis Antoniou
<pantelis.antoniou at konsulko.com> wrote:

> From: Georgi Vlaev <gvlaev at juniper.net>
>
> This driver exports the CB FPGA presence detect bits from a
> single 32bit CB register as GPIOs.
>
> Signed-off-by: Georgi Vlaev <gvlaev at juniper.net>
> Signed-off-by: Guenter Roeck <groeck at juniper.net>
> [Ported from Juniper kernel]
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou at konsulko.com>

This needs some more verbose commit message and explanation.

Note: GPIO = General Purpose Input/Output.

This doesn't really sound like general purpose, more like special
purpose.

Consider drivers/input and drivers/connector classes for example.

> +config GPIO_CBC_PRESENCE
> +       tristate "Juniper Networks PTX1K CBC presence detect as GPIO"
> +       depends on MFD_JUNIPER_CBC && OF
> +       default y if JNX_CONNECTOR
> +       help
> +         This driver exports the CH_PRS and OTHER_CH_PRS presence detect
> +         bits of the PTX1K RCB CBC FPGA as GPIOs on the relevant Juniper
> +         platforms. Select if JNX_CONNECTOR is selected.
> +
> +         This driver can also be built as a module.  If so, the module
> +         will be called gpio-cbc-presence.

At least tell us *what* it is detecting the presence of.

Apart from this it has some of the same issues pointed out in the
other drivers, correct these as well.

Yours,
Linus Walleij


More information about the devel mailing list