[PATCH] staging: rtl8188eu: os_dep: fix checkpatch issues

Greg Kroah-Hartman gregkh at linuxfoundation.org
Wed Oct 19 07:37:55 UTC 2016


On Tue, Oct 18, 2016 at 11:30:29PM +0200, Pierre-Yves Kerbrat wrote:
> This patch fixes the following:
> - fix 2 block comments
> - add missing spaces around operators
> - remove unnecessary kzalloc fail message
> - fix line over 80 char
> ...

When you find yourself listing all of the different things a single
patch does, that's a huge hint that you need to break it up into
multiple patches.

Each patch should only do one "logical" thing.  And no, "fix all
checkpatch issues" is not one logical thing :)

Please redo this as a patch series.

thanks,

greg k-h


More information about the devel mailing list