[PATCH] Staging: media: bcm2048: Use octal permissions '0444'

Shyam Saini mayhs11saini at gmail.com
Tue Oct 18 12:22:21 UTC 2016


On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote:
> On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote:
> > 
> > On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote:
> > > 
> > > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote:
> > > > 
> > > > 
> > > > Fixed following checkpatch warning
> > > > Symbolic permissions 'S_IRUGO' are not preferred. Consider
> > > > using
> > > > octal
> > > > permissions '0444'
> > > > 
> > > > Signed-off-by: Shyam Saini <mayhs11saini at gmail.com>
> > > > ---
> > > >  drivers/staging/media/bcm2048/radio-bcm2048.c | 18 +++++++++
> > > > ----
> > > > -----
> > > >  1 file changed, 9 insertions(+), 9 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > > b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > > index 5d2b702..9c286c3 100644
> > > > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > > @@ -2103,21 +2103,21 @@ static struct device_attribute attrs[]
> > > > = {
> > > >  	       bcm2048_rds_pi_match_write),
> > > >  	__ATTR(rds_wline, 0644, bcm2048_rds_wline_read,
> > > >  	       bcm2048_rds_wline_write),
> > > > -	__ATTR(rds_pi, S_IRUGO, bcm2048_rds_pi_read, NULL),
> > > > -	__ATTR(rds_rt, S_IRUGO, bcm2048_rds_rt_read, NULL),
> > > > -	__ATTR(rds_ps, S_IRUGO, bcm2048_rds_ps_read, NULL),
> > > > -	__ATTR(fm_rds_flags, S_IRUGO,
> > > > bcm2048_fm_rds_flags_read,
> > > > NULL),
> > > > -	__ATTR(region_bottom_frequency, S_IRUGO,
> > > > +	__ATTR(rds_pi, 0444, bcm2048_rds_pi_read, NULL),
> > > > +	__ATTR(rds_rt, 0444, bcm2048_rds_rt_read, NULL),
> > > > +	__ATTR(rds_ps, 0444, bcm2048_rds_ps_read, NULL),
> > > > +	__ATTR(fm_rds_flags, 0444, bcm2048_fm_rds_flags_read,
> > > > NULL),
> > > > +	__ATTR(region_bottom_frequency, 0444,
> > > >  	       bcm2048_region_bottom_frequency_read, NULL),
> > 
> > > 
> > > Why not use __ATTR_RO() for all of these instead?
> > I just used what checkpatch.pl suggested. Now I'll
> > use  __ATTR_RO().
> > 
> > Also shouldn't we change checkpatch.pl accordingly ?
> No, not all octal values should be converted that way.

> checkpatch is a "hint", not always the exact thing that needs to be
> done, and sometimes it should be ignored.  Please always use your
> judgement.

I have used __ATTR_RO()  __ATTR_RW(). But, when I build it, i got so
many error messages and build fails. I'm attaching a file containing
errors.

Thanks,
Shyam 
-------------- next part --------------
In file included from ./include/linux/kobject.h:21:0,
                 from ./include/linux/module.h:17,
                 from drivers/staging//media/bcm2048/radio-bcm2048.c:37:
drivers/staging//media/bcm2048/radio-bcm2048.c:2060:12: error: ‘power_state_show’ undeclared here (not in a function)
  __ATTR_RW(power_state),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2060:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(power_state),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2060:12: error: ‘power_state_store’ undeclared here (not in a function)
  __ATTR_RW(power_state),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2060:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(power_state),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2061:12: error: ‘mute_show’ undeclared here (not in a function)
  __ATTR_RW(mute),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2061:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(mute),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2061:12: error: ‘mute_store’ undeclared here (not in a function)
  __ATTR_RW(mute),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2061:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(mute),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2062:12: error: ‘audio_route_show’ undeclared here (not in a function)
  __ATTR_RW(audio_route),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2062:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(audio_route),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2062:12: error: ‘audio_route_store’ undeclared here (not in a function)
  __ATTR_RW(audio_route),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2062:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(audio_route),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2063:12: error: ‘dac_output_show’ undeclared here (not in a function)
  __ATTR_RW(dac_output),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2063:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(dac_output),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2063:12: error: ‘dac_output_store’ undeclared here (not in a function)
  __ATTR_RW(dac_output),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2063:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(dac_output),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2064:12: error: ‘fm_hi_lo_injection_show’ undeclared here (not in a function)
  __ATTR_RW(fm_hi_lo_injection),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2064:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_hi_lo_injection),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2064:12: error: ‘fm_hi_lo_injection_store’ undeclared here (not in a function)
  __ATTR_RW(fm_hi_lo_injection),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2064:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_hi_lo_injection),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2065:12: error: ‘fm_frequency_show’ undeclared here (not in a function)
  __ATTR_RW(fm_frequency),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2065:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_frequency),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2065:12: error: ‘fm_frequency_store’ undeclared here (not in a function)
  __ATTR_RW(fm_frequency),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2065:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_frequency),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2066:12: error: ‘fm_af_frequency_show’ undeclared here (not in a function)
  __ATTR_RW(fm_af_frequency),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2066:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_af_frequency),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2066:12: error: ‘fm_af_frequency_store’ undeclared here (not in a function)
  __ATTR_RW(fm_af_frequency),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2066:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_af_frequency),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2067:12: error: ‘fm_deemphasis_show’ undeclared here (not in a function)
  __ATTR_RW(fm_deemphasis),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2067:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_deemphasis),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2067:12: error: ‘fm_deemphasis_store’ undeclared here (not in a function)
  __ATTR_RW(fm_deemphasis),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2067:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_deemphasis),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2068:12: error: ‘fm_rds_mask_show’ undeclared here (not in a function)
  __ATTR_RW(fm_rds_mask),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2068:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_rds_mask),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2068:12: error: ‘fm_rds_mask_store’ undeclared here (not in a function)
  __ATTR_RW(fm_rds_mask),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2068:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_rds_mask),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2069:12: error: ‘fm_best_tune_mode_show’ undeclared here (not in a function)
  __ATTR_RW(fm_best_tune_mode),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2069:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_best_tune_mode),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2069:12: error: ‘fm_best_tune_mode_store’ undeclared here (not in a function)
  __ATTR_RW(fm_best_tune_mode),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2069:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_best_tune_mode),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2070:12: error: ‘fm_search_rssi_threshold_show’ undeclared here (not in a function)
  __ATTR_RW(fm_search_rssi_threshold),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2070:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_search_rssi_threshold),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2070:12: error: ‘fm_search_rssi_threshold_store’ undeclared here (not in a function)
  __ATTR_RW(fm_search_rssi_threshold),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2070:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_search_rssi_threshold),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2071:12: error: ‘fm_search_mode_direction_show’ undeclared here (not in a function)
  __ATTR_RW(fm_search_mode_direction),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2071:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_search_mode_direction),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2071:12: error: ‘fm_search_mode_direction_store’ undeclared here (not in a function)
  __ATTR_RW(fm_search_mode_direction),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2071:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_search_mode_direction),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2072:12: error: ‘fm_search_tune_mode_show’ undeclared here (not in a function)
  __ATTR_RW(fm_search_tune_mode),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2072:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_search_tune_mode),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2072:12: error: ‘fm_search_tune_mode_store’ undeclared here (not in a function)
  __ATTR_RW(fm_search_tune_mode),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2072:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(fm_search_tune_mode),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2073:12: error: ‘rds_show’ undeclared here (not in a function)
  __ATTR_RW(rds),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2073:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2073:12: error: ‘rds_store’ undeclared here (not in a function)
  __ATTR_RW(rds),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2073:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2074:12: error: ‘rds_b_block_mask_show’ undeclared here (not in a function)
  __ATTR_RW(rds_b_block_mask),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2074:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_b_block_mask),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2074:12: error: ‘rds_b_block_mask_store’ undeclared here (not in a function)
  __ATTR_RW(rds_b_block_mask),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2074:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_b_block_mask),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2075:12: error: ‘rds_b_block_match_show’ undeclared here (not in a function)
  __ATTR_RW(rds_b_block_match),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2075:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_b_block_match),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2075:12: error: ‘rds_b_block_match_store’ undeclared here (not in a function)
  __ATTR_RW(rds_b_block_match),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2075:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_b_block_match),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2076:12: error: ‘rds_pi_mask_show’ undeclared here (not in a function)
  __ATTR_RW(rds_pi_mask),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2076:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_pi_mask),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2076:12: error: ‘rds_pi_mask_store’ undeclared here (not in a function)
  __ATTR_RW(rds_pi_mask),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2076:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_pi_mask),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2077:12: error: ‘rds_pi_match_show’ undeclared here (not in a function)
  __ATTR_RW(rds_pi_match),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2077:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_pi_match),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2077:12: error: ‘rds_pi_match_store’ undeclared here (not in a function)
  __ATTR_RW(rds_pi_match),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2077:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_pi_match),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2078:12: error: ‘rds_wline_show’ undeclared here (not in a function)
  __ATTR_RW(rds_wline),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2078:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_wline),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2078:12: error: ‘rds_wline_store’ undeclared here (not in a function)
  __ATTR_RW(rds_wline),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2078:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(rds_wline),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2079:12: error: ‘rds_pi_show’ undeclared here (not in a function)
  __ATTR_RO(rds_pi),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2080:12: error: ‘rds_rt_show’ undeclared here (not in a function)
  __ATTR_RO(rds_rt),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2081:12: error: ‘rds_ps_show’ undeclared here (not in a function)
  __ATTR_RO(rds_ps),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2082:12: error: ‘fm_rds_flags_show’ undeclared here (not in a function)
  __ATTR_RO(fm_rds_flags),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2083:12: error: ‘region_bottom_frequency_show’ undeclared here (not in a function)
  __ATTR_RO(region_bottom_frequency),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2084:12: error: ‘region_top_frequency_show’ undeclared here (not in a function)
  __ATTR_RO(region_top_frequency),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2085:12: error: ‘fm_carrier_error_show’ undeclared here (not in a function)
  __ATTR_RO(fm_carrier_error),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2086:12: error: ‘fm_rssi_show’ undeclared here (not in a function)
  __ATTR_RO(fm_rssi),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2087:12: error: ‘region_show’ undeclared here (not in a function)
  __ATTR_RW(region),
            ^
./include/linux/sysfs.h:103:10: note: in definition of macro ‘__ATTR’
  .show = _show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2087:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(region),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2087:12: error: ‘region_store’ undeclared here (not in a function)
  __ATTR_RW(region),
            ^
./include/linux/sysfs.h:104:11: note: in definition of macro ‘__ATTR’
  .store = _store,      \
           ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2087:2: note: in expansion of macro ‘__ATTR_RW’
  __ATTR_RW(region),
  ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2088:12: error: ‘rds_data_show’ undeclared here (not in a function)
  __ATTR_RO(rds_data),
            ^
./include/linux/sysfs.h:116:10: note: in definition of macro ‘__ATTR_RO’
  .show = _name##_show,      \
          ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_power_state_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2025:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_power_state_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2025:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_mute_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2026:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_mute_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2026:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_audio_route_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2027:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_audio_route_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2027:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_dac_output_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2028:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_dac_output_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2028:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_hi_lo_injection_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2030:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_hi_lo_injection_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2030:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_frequency_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2031:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_frequency_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2031:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_af_frequency_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2032:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_af_frequency_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2032:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_deemphasis_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_deemphasis_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_rds_mask_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2034:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_rds_mask_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2034:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_best_tune_mode_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2035:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_best_tune_mode_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2035:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_search_rssi_threshold_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2036:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_search_rssi_threshold_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2036:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_search_mode_direction_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2037:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_search_mode_direction_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2037:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_fm_search_tune_mode_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2038:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_search_tune_mode_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2038:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_rds_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2040:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_rds_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2040:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_rds_b_block_mask_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2041:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_rds_b_block_mask_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2041:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_rds_b_block_match_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2042:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_rds_b_block_match_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2042:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_rds_pi_mask_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2043:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_rds_pi_mask_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2043:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_rds_pi_match_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2044:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_rds_pi_match_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2044:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_rds_wline_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2045:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_rds_wline_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2045:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_rds_pi_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2046:1: note: in expansion of macro ‘property_read’
 property_read(rds_pi, unsigned int, "%x")
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2002:16: warning: ‘bcm2048_rds_rt_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2047:1: note: in expansion of macro ‘property_str_read’
 property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2002:16: warning: ‘bcm2048_rds_ps_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2048:1: note: in expansion of macro ‘property_str_read’
 property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_fm_rds_flags_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2050:1: note: in expansion of macro ‘property_read’
 property_read(fm_rds_flags, unsigned int, "%u")
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2002:16: warning: ‘bcm2048_rds_data_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2051:1: note: in expansion of macro ‘property_str_read’
 property_str_read(rds_data, BCM2048_MAX_RDS_RADIO_TEXT * 5)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_region_bottom_frequency_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2053:1: note: in expansion of macro ‘property_read’
 property_read(region_bottom_frequency, unsigned int, "%u")
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_region_top_frequency_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2054:1: note: in expansion of macro ‘property_read’
 property_read(region_top_frequency, unsigned int, "%u")
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1982:16: warning: ‘bcm2048_fm_carrier_error_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2055:1: note: in expansion of macro ‘property_signed_read’
 property_signed_read(fm_carrier_error, int, "%d")
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1982:16: warning: ‘bcm2048_fm_rssi_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2056:1: note: in expansion of macro ‘property_signed_read’
 property_signed_read(fm_rssi, int, "%d")
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1939:16: warning: ‘bcm2048_region_write’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_write(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1998:1: note: in expansion of macro ‘property_write’
 property_write(prop, signal size, mask, check)    \
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2057:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1963:16: warning: ‘bcm2048_region_read’ defined but not used [-Wunused-function]
 static ssize_t bcm2048_##prop##_read(struct device *dev,  \
                ^
drivers/staging//media/bcm2048/radio-bcm2048.c:1999:1: note: in expansion of macro ‘property_read’
 property_read(prop, size, mask)
 ^
drivers/staging//media/bcm2048/radio-bcm2048.c:2057:1: note: in expansion of macro ‘DEFINE_SYSFS_PROPERTY’
 DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
 ^
scripts/Makefile.build:296: recipe for target 'drivers/staging//media/bcm2048/radio-bcm2048.o' failed
make[3]: *** [drivers/staging//media/bcm2048/radio-bcm2048.o] Error 1
scripts/Makefile.build:475: recipe for target 'drivers/staging//media/bcm2048' failed
make[2]: *** [drivers/staging//media/bcm2048] Error 2
scripts/Makefile.build:475: recipe for target 'drivers/staging//media' failed
make[1]: *** [drivers/staging//media] Error 2
Makefile:1482: recipe for target '_module_drivers/staging/' failed
make: *** [_module_drivers/staging/] Error 2



More information about the devel mailing list