[PATCH] Staging: media: bcm2048: Use octal permissions '0644'

Greg KH gregkh at linuxfoundation.org
Mon Oct 17 16:07:52 UTC 2016


On Mon, Oct 17, 2016 at 09:23:07PM +0530, Shyam Saini wrote:
> Fixed following checkpatch.pl warning
> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> 
> Signed-off-by: Shyam Saini <mayhs11saini at gmail.com>
> ---
>  drivers/staging/media/bcm2048/radio-bcm2048.c | 40 +++++++++++++--------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index ea15cc6..5d2b702 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2057,51 +2057,51 @@ property_signed_read(fm_rssi, int, "%d")
>  DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
>  
>  static struct device_attribute attrs[] = {
> -	__ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
> +	__ATTR(power_state, 0644, bcm2048_power_state_read,
>  	       bcm2048_power_state_write),

Why not use __ATTR_RW() instead?

thanks,

greg k-h


More information about the devel mailing list