[patch] staging: android/ion: testing the wrong variable

Laura Abbott labbott at redhat.com
Wed Oct 12 22:39:20 UTC 2016


On 10/11/2016 11:20 PM, Dan Carpenter wrote:
> We're testing "pdev" but we intended to test "heap_pdev".  This is a
> static checker fix and it's unlikely that anyone is affected by this
> bug.
>
> Fixes: 13439479c7de ('staging: ion: Add files for parsing the devicetree')
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>

Acked-by: Laura Abbott <labbott at redhat.com>

> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
> index 15bac92..46b2bb9 100644
> --- a/drivers/staging/android/ion/ion_of.c
> +++ b/drivers/staging/android/ion/ion_of.c
> @@ -107,7 +107,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev,
>
>  		heap_pdev = of_platform_device_create(node, heaps[i].name,
>  						      &pdev->dev);
> -		if (!pdev)
> +		if (!heap_pdev)
>  			return ERR_PTR(-ENOMEM);
>  		heap_pdev->dev.platform_data = &heaps[i];
>
>



More information about the devel mailing list