[PATCH v4] staging: greybus: Fix a commit coding style issue.

Vaishali Thakkar vaishali.thakkar at oracle.com
Tue Oct 4 04:35:31 UTC 2016



On Monday 03 October 2016 04:21 PM, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue
> found by checkpatch.
> 
> Signed-off-by: Sidhant Gupta <guptasidhant004 at gmail.com>

Reviewed-by: Vaishali Thakkar <vaishali.thakkar at oracle.com>

> ---
> 
> Changes since v3:
> * Corrected checkpatch.pl error earlier caused by this patch.

Just on a side note, here you are supposed to write changes since first
version. No need to resend the patch. But take care of this thing in
next patches.
 
>  drivers/staging/greybus/arche-apb-ctrl.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
> index 70323aa..103d629 100644
> --- a/drivers/staging/greybus/arche-apb-ctrl.c
> +++ b/drivers/staging/greybus/arche-apb-ctrl.c
> @@ -285,8 +285,10 @@ static ssize_t state_store(struct device *dev,
>  		if (apb->state == ARCHE_PLATFORM_STATE_FW_FLASHING)
>  			return count;
>  
> -		/* First we want to make sure we power off everything
> -		 * and then enter FW flashing state */
> +		/*
> +		 * First we want to make sure we power off everything
> +		 * and then enter FW flashing state
> +		 */
>  		poweroff_seq(pdev);
>  		ret = fw_flashing_seq(pdev);
>  	} else {
> 

-- 
Vaishali


More information about the devel mailing list