[PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

Dan Carpenter dan.carpenter at oracle.com
Wed Nov 30 18:31:25 UTC 2016


On Wed, Nov 30, 2016 at 06:04:14PM +0330, Saber Rezvani wrote:
> @@ -1035,7 +1035,7 @@ static int s626_dio_set_irq(struct comedi_device *dev, unsigned int chan)
>  	return 0;
>  }
>  
> -static int s626_dio_reset_irq(struct comedi_device *dev, unsigned int group,
> +static int s626_dio_reset_irq(struct comedi_device *dev, u8 group,
>  			      unsigned int mask)
>  {
>  	/* disable edge capture write command */

This change isn't wrong, but it should be in a different patch or at the
very least mentioned in the changelog.

regards,
dan carpenter



More information about the devel mailing list