[PATCH] staging: greybuis: fix permission style warnings

[Andrea Ghittino]

On Wed, Nov 30, 2016 at 12:21 AM, Dan Carpenter
<dan.carpenter at oracle.com> wrote:
> On Tue, Nov 29, 2016 at 03:59:46PM -0600, Alex Elder wrote:
>> On 11/26/2016 03:50 PM, Andrea Ghittino wrote:
>> > Fixes greybus user/groups permission style warnings
>> > found by checkpatch.pl tool
>> >
>> > Signed-off-by: Andrea Ghittino <aghittino at gmail.com>
>>
>> I don't understand why using 0444 would be preferred
>> over S_IRUGO (for example).  Do you know?  Maybe the
>> checkpatch.pl output says something about it.  There
>> may well be a good reason, but otherwise I prefer
>> using the symbolic constants (and therefore *not*
>> applying this patch).
>>
>>                                       -Alex
>
> At first, the checkpatch prefered S_IRUGO.  But Linus was like actually
> I prefer 0444 so then checkpatch was updated to the opposite.
>
> I personally think S_IRUGO is much easier...  But whatever.  You can't
> stand in the way of progress.  My advice is don't fight checkpatch, just
> roll with it.
>
> regards,
> dan carpenter
>

Honestly, for a kernel newbie it is difficult to manage. I received 2
email that suggest
to use S_IRUGO. My original patch was with octal, based on checkpatch.pl advice.

andrea