[PATCH v4 18/26] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

Jonathan Cameron jic23 at kernel.org
Sun Nov 13 12:23:40 UTC 2016


On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.
> Replace this with sizeof(value[1]).
> 
> Signed-off-by: Brian Masney <masneyb at onstation.org>
Applied.
> ---
>  drivers/staging/iio/light/tsl2583.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index fe9d777..78967dc 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -582,7 +582,7 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
>  
>  	/* Zero out the table */
>  	memset(tsl2583_device_lux, 0, sizeof(tsl2583_device_lux));
> -	memcpy(tsl2583_device_lux, &value[1], value[0] * 4);
> +	memcpy(tsl2583_device_lux, &value[1], value[0] * sizeof(value[1]));
>  
>  	ret = len;
>  
> 



More information about the devel mailing list