[PATCH 03/15] staging: comedi: ni_routing: Add NI signal routing info

Thu Nov 10 18:16:16 UTC 2016

On 10/11/16 17:54, Greg Kroah-Hartman wrote:
> On Thu, Nov 10, 2016 at 05:08:36PM +0000, Ian Abbott wrote:
>> On 12/10/16 12:05, Spencer E. Olson wrote:
>>> See README for a thorough discussion of this content.
>>>
>>> Adds two different collections of CSV files that:
>>> 1) summarize the various register values for creating routes
>>>    for a particular family of NI hardware devices;
>>> 2) summarize all possible (direct) routes that a particular device can
>>>    make--in this case, one file per device (this data is currently only
>>>    known to be found by examining a screenshot of the "Available Routes"
>>>    tab of NI MAX control panel, which is only found on Windows
>>>    installations of the NI driver).
>>>
>>> The collection and maintenance of this information is somewhat tedious and
>>> requires frequent re-examination and comparison of NI-MAX and/or the NI-MHDDK
>>> documentation (register programming information) and NI-MHDDK examples.
>>> These CSV files are constructed so-as to allow near direct comparison
>>> to NI-MAX and NI-MHDDK.  As such, these serve to ease the task of
>>> maintaining this knowledge and more quickly enables addition of new NI
>>> devices.
>>>
>>> Signed-off-by: Spencer E. Olson <olsonse at umich.edu>
>>>
>>> *** PLEASE FIND ACTUAL PATCH AT:
>>> http://www.umich.edu/~olsonse/patches/comedi-devglobal-v1/0003-staging-comedi-ni_routing-Add-NI-signal-routing-info.patch
>>>
>>> (This patch included some lines that were too long for email)
>>> ---
>>>  drivers/staging/comedi/drivers/ni_routing/README   | 110 +++++++++++++++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6070E.csv      |  40 ++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6220.csv       |  46 +++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6221.csv       |  50 ++++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6251.csv       |  51 ++++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6254.csv       |  47 +++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6259.csv       |  51 ++++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6534.csv       |  29 ++++++
>>>  .../ni_routing/ni_device_routes/PCI-6602.csv       |  78 +++++++++++++++
>>>  .../ni_routing/ni_device_routes/PCI-6713.csv       |  32 ++++++
>>>  .../ni_routing/ni_device_routes/PCI-6723.csv       |  32 ++++++
>>>  .../ni_routing/ni_device_routes/PCI-6733.csv       |  34 +++++++
>>>  .../ni_routing/ni_device_routes/PXI-6030E.csv      |  39 ++++++++
>>>  .../ni_routing/ni_device_routes/PXI-6224.csv       |  46 +++++++++
>>>  .../ni_routing/ni_device_routes/PXI-6225.csv       |  49 +++++++++
>>>  .../ni_routing/ni_device_routes/PXI-6251.csv       |  50 ++++++++++
>>>  .../ni_routing/ni_device_routes/PXI-6733.csv       |  35 +++++++
>>>  .../ni_routing/ni_device_routes/PXIe-6251.csv      |  52 ++++++++++
>>>  .../drivers/ni_routing/ni_route_values/ni_660x.csv | 100 +++++++++++++++++++
>>>  .../ni_routing/ni_route_values/ni_eseries.csv      |  78 +++++++++++++++
>>>  .../ni_routing/ni_route_values/ni_mseries.csv      |  90 +++++++++++++++++
>>>  21 files changed, 1139 insertions(+)
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/README
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6070E.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6220.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6221.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6251.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6254.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6259.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6534.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6602.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6713.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6723.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PCI-6733.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PXI-6030E.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PXI-6224.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PXI-6225.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PXI-6251.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PXI-6733.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_device_routes/PXIe-6251.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_route_values/ni_660x.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_route_values/ni_eseries.csv
>>>  create mode 100644 drivers/staging/comedi/drivers/ni_routing/ni_route_values/ni_mseries.csv
>>>
>>> <... SNIP ...>
>>>
>>
>> While it's nice to have the source data for the generated C files, I'm a bit
>> worried that any future patches to these .csv files will also be
>> incompatible with sending by email.  I'm not sure of the best way to deal
>> with this.
>
> They should work in email, it's just a text file and patch handles that
> fine.
>

Its the line lengths I'm worried about, i.e. the reason this patch 
couldn't be sent by email!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-