[PATCH v9 net-next 1/2] hv_sock: introduce Hyper-V Sockets
Dexuan Cui
decui at microsoft.com
Sat May 7 10:49:25 UTC 2016
> From: David Miller [mailto:davem at davemloft.net]
> Sent: Saturday, May 7, 2016 1:04
> To: Dexuan Cui <decui at microsoft.com>
> Cc: gregkh at linuxfoundation.org; netdev at vger.kernel.org; linux-
> kernel at vger.kernel.org; devel at linuxdriverproject.org; olaf at aepfle.de;
> apw at canonical.com; jasowang at redhat.com; cavery at redhat.com; KY
> Srinivasan <kys at microsoft.com>; Haiyang Zhang <haiyangz at microsoft.com>;
> joe at perches.com; vkuznets at redhat.com
> Subject: Re: [PATCH v9 net-next 1/2] hv_sock: introduce Hyper-V Sockets
>
> From: Dexuan Cui <decui at microsoft.com>
> Date: Wed, 4 May 2016 09:56:57 -0700
>
> > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_RECV (5 * PAGE_SIZE)
> > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_SEND (5 * PAGE_SIZE)
> > +
> > +#define HVSOCK_RCV_BUF_SZ
> VMBUS_RINGBUFFER_SIZE_HVSOCK_RECV
> ...
> > +struct hvsock_sock {
> ...
> > + /* The 'hdr' and 'buf' in the below 'send' and 'recv' definitions must
> > + * be consecutive: see hvsock_send_data() and hvsock_recv_data().
> > + */
> > + struct {
> > + struct vmpipe_proto_header hdr;
> > + u8 buf[HVSOCK_SND_BUF_SZ];
> > + } send;
> > +
> > + struct {
> > + struct vmpipe_proto_header hdr;
> > + u8 buf[HVSOCK_RCV_BUF_SZ];
> > +
> > + unsigned int data_len;
> > + unsigned int data_offset;
> > + } recv;
>
> I don't think allocating 5 pages of unswappable memory for every Hyper-V
> socket
> created is reasonable.
Thanks for the comment, David!
I should be able to make 'send', 'recv' here to pointers and use vmalloc()
to allocate the memory for them. I will do this.
Thanks,
-- Dexuan
More information about the devel
mailing list