[PATCH] staging/lustre/libcfs: Copy correct amount in libcfs_ioctl_getdata

Simmons, James A. simmonsja at ornl.gov
Tue Mar 29 15:30:23 UTC 2016


>Commit b8ff756bc351 ("staging: lustre: libcfs: merge code from
>libcfs_ioctl into libcfs_ioctl_getdata") introduced a problem
>copying just a single pointer worth of data from userspace
>instead of whole libcfs_ioctl_hdr structure.
>Adjust the copying amount.
>
>Signed-off-by: Oleg Drokin <green at linuxhacker.ru>

Acked- by: James Simmons <jsimmons at infradead.org>

>---
> drivers/staging/lustre/lnet/libcfs/linux/linux-module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-module.c b/drivers/staging/lustre/lnet/libcfs/linux/linux-module.c
>index b86e937..d89f71e 100644
>--- a/drivers/staging/lustre/lnet/libcfs/linux/linux-module.c
>+++ b/drivers/staging/lustre/lnet/libcfs/linux/linux-module.c
>@@ -128,7 +128,7 @@ int libcfs_ioctl_getdata(struct libcfs_ioctl_hdr **hdr_pp,
> 	struct libcfs_ioctl_hdr hdr;
> 	int err = 0;
>
>-	if (copy_from_user(&hdr, uhdr, sizeof(uhdr)))
>+	if (copy_from_user(&hdr, uhdr, sizeof(hdr)))
> 		return -EFAULT;
> 
> 	if (hdr.ioc_version != LIBCFS_IOCTL_VERSION &&
>-- 
>2.1.0

_______________________________________________
devel mailing list
devel at linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



More information about the devel mailing list