[PATCH] staging: comedi: ni_mio_common: fix the ni_write[blw]() functions

gregkh at linuxfoundation.org gregkh at linuxfoundation.org
Fri Mar 18 17:47:36 UTC 2016


On Fri, Mar 18, 2016 at 05:38:45PM +0000, Hartley Sweeten wrote:
> On Wednesday, March 16, 2016 3:22 AM, Ian Abbott wrote:
> > On 15/03/16 21:48, H Hartley Sweeten wrote:
> >> Memory mapped io (dev->mmio) should not also be writing to the ioport
> >> (dev->iobase) registers. Add the missing 'else' to these functions.
> >>
> >> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> >> Cc: Ian Abbott <abbotti at mev.co.uk>
> >> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> >> ---
> >>   drivers/staging/comedi/drivers/ni_mio_common.c | 12 ++++++------
> >>   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > Please add:
> >
> > Fixes: 0953ee4acca0 ("staging: comedi: ni_mio_common: checkpatch.pl 
> > cleanup (else not useful)")
> > Cc: <stable at vger.kernel.org> # 3.17+
> >
> > Reviewed-by: Ian Abbott <abbotti at mev.co.uk>
> 
> Ugh... Looks like I broke it.
> 
> Greg,
> 
> Would you like me to repost this with the Fixes/Cc added or do you got it?

I got it, no problem.

greg k-h


More information about the devel mailing list