[PATCH] staging: speakup: fix type mismatch warnings

Greg KH gregkh at linuxfoundation.org
Fri Mar 11 22:32:52 UTC 2016


On Thu, Mar 10, 2016 at 08:21:35PM +0000, Okash Khawaja wrote:
> Compiling speakup driver with sparse produces following warning:
> 
> drivers/staging/speakup/serialio.c:22:9: warning: incorrect type in
> initializer (different base types)
> drivers/staging/speakup/serialio.c:22:9:    expected unsigned int
> [unsigned] flags
> drivers/staging/speakup/serialio.c:22:9:    got restricted upf_t
> 
> This patch fixes it.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja at gmail.com>
> ---
>  drivers/staging/speakup/serialio.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/serialio.h b/drivers/staging/speakup/serialio.h
> index 1b39921..3ad7ff0 100644
> --- a/drivers/staging/speakup/serialio.h
> +++ b/drivers/staging/speakup/serialio.h
> @@ -6,6 +6,7 @@
>  #ifndef __sparc__
>  #include <linux/serial.h>
>  #endif
> +#include <linux/serial_core.h>
>  
>  /*
>   * this is cut&paste from 8250.h. Get rid of the structure, the definitions
> @@ -16,7 +17,7 @@ struct old_serial_port {
>  	unsigned int baud_base;
>  	unsigned int port;
>  	unsigned int irq;
> -	unsigned int flags; /* unused */
> +	upf_t flags; /* unused */
>  };
>  
>  /* countdown values for serial timeouts in us */
> -- 
> 2.5.2

I need some agreement from the speakup developers about this, I don't
know if it's really needed or not...

thanks,

greg k-h


More information about the devel mailing list