[PATCH V4] staging: rtl8192u: check return value of read_nic_word_E

Greg KH gregkh at linuxfoundation.org
Fri Mar 11 17:57:09 UTC 2016


On Tue, Mar 08, 2016 at 03:55:49AM +0100, Salah Triki wrote:
> The call of read_nic_word_E may fail, therefore its return value must be
> checked.

That's good, but you are doing two different things here, fixing
read_nic_word_E and then changing the return value of some functions
that call that function.

Please break this up into a patch series, that is easier to review, and
that only does one thing per patch, this tries to do too much all at
ocne.

thanks,

greg k-h


More information about the devel mailing list