[staging:staging-next 1186/1234] drivers/staging/lustre/lustre/llite/file.c:2749:7: error: 'F_SETLKW64' undeclared

Oleg Drokin green at linuxhacker.ru
Wed Mar 2 08:29:24 UTC 2016


On Mar 2, 2016, at 2:31 AM, kbuild test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
> head:   5a9ff74d8e681f9ac6af6cc1444a812b74e7c2de
> commit: caa88c26575c9be856e5a801abd121d7ff0808f8 [1186/1234] staging/lustre: F_SETLKW64 F_SETLK64 F_GETLK64 are always defined
> config: alpha-allmodconfig (attached as .config)
> reproduce:
>        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>        chmod +x ~/bin/make.cross
>        git checkout caa88c26575c9be856e5a801abd121d7ff0808f8
>        # save the attached .config to linux build tree
>        make.cross ARCH=alpha 
> 
> All errors (new ones prefixed by >>):
> 
>   drivers/staging/lustre/lustre/llite/file.c: In function 'll_file_flock':
>>> drivers/staging/lustre/lustre/llite/file.c:2749:7: error: 'F_SETLKW64' undeclared (first use in this function)
>     case F_SETLKW64:
>          ^

Duh, so alpha does not ever define those and even though there is code in the kernel that uses them unconditionally
(fs/compat.c), it depends on CONFIG_COMPAT that is never defined for alpha (because there was never 32 bit compat there?)

Anyway, in light of this I guess this patch needs to be reverted then.

Greg, how do I make that happen, do you want a reversal patch or can you revert it yourself somehow?

Thanks.

>   drivers/staging/lustre/lustre/llite/file.c:2749:7: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/staging/lustre/lustre/llite/file.c:2753:7: error: 'F_SETLK64' undeclared (first use in this function)
>     case F_SETLK64:
>          ^
>>> drivers/staging/lustre/lustre/llite/file.c:2757:7: error: 'F_GETLK64' undeclared (first use in this function)
>     case F_GETLK64:
>          ^
> 
> vim +/F_SETLKW64 +2749 drivers/staging/lustre/lustre/llite/file.c
> 
> d7e09d039 Peng Tao           2013-05-02  2743  		       file_lock->fl_type);
> 0a3bdb007 Greg Kroah-Hartman 2013-08-03  2744  		return -ENOTSUPP;
> d7e09d039 Peng Tao           2013-05-02  2745  	}
> d7e09d039 Peng Tao           2013-05-02  2746  
> d7e09d039 Peng Tao           2013-05-02  2747  	switch (cmd) {
> d7e09d039 Peng Tao           2013-05-02  2748  	case F_SETLKW:
> d7e09d039 Peng Tao           2013-05-02 @2749  	case F_SETLKW64:
> d7e09d039 Peng Tao           2013-05-02  2750  		flags = 0;
> d7e09d039 Peng Tao           2013-05-02  2751  		break;
> d7e09d039 Peng Tao           2013-05-02  2752  	case F_SETLK:
> d7e09d039 Peng Tao           2013-05-02 @2753  	case F_SETLK64:
> d7e09d039 Peng Tao           2013-05-02  2754  		flags = LDLM_FL_BLOCK_NOWAIT;
> d7e09d039 Peng Tao           2013-05-02  2755  		break;
> d7e09d039 Peng Tao           2013-05-02  2756  	case F_GETLK:
> d7e09d039 Peng Tao           2013-05-02 @2757  	case F_GETLK64:
> d7e09d039 Peng Tao           2013-05-02  2758  		flags = LDLM_FL_TEST_LOCK;
> d7e09d039 Peng Tao           2013-05-02  2759  		/* Save the old mode so that if the mode in the lock changes we
> c0894c6cf Oleg Drokin        2016-02-24  2760  		 * can decrement the appropriate reader or writer refcount.
> 
> :::::: The code at line 2749 was first introduced by commit
> :::::: d7e09d0397e84eefbabfd9cb353221f3c6448d83 staging: add Lustre file system client support
> 
> :::::: TO: Peng Tao <bergwolf at gmail.com>
> :::::: CC: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> <.config.gz>



More information about the devel mailing list