[PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

Dexuan Cui decui at microsoft.com
Thu Jun 30 14:33:19 UTC 2016


> From: David Miller [mailto:davem at davemloft.net]
> Sent: Thursday, June 30, 2016 20:45
> To: Dexuan Cui <decui at microsoft.com>
> Cc: gregkh at linuxfoundation.org; netdev at vger.kernel.org; linux-
> kernel at vger.kernel.org; devel at linuxdriverproject.org; olaf at aepfle.de;
> apw at canonical.com; jasowang at redhat.com; vkuznets at redhat.com;
> cavery at redhat.com; KY Srinivasan <kys at microsoft.com>; Haiyang Zhang
> <haiyangz at microsoft.com>; joe at perches.com; rolf.neugebauer at docker.com
> Subject: Re: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets
> 
> From: Dexuan Cui <decui at microsoft.com>
> Date: Wed, 29 Jun 2016 11:30:40 +0000
> 
> > @@ -1509,4 +1509,18 @@ static inline void commit_rd_index(struct
> vmbus_channel *channel)
> >  }
> >
> >
> > +struct vmpipe_proto_header {
> > +	u32 pkt_type;
> 
> It is wasteful to have two empty lines before this structure definition, one
> is sufficient.
> 
> ...

Hi David,
Thank you for pointing out the issues!

I'll fix all of them, and check all the similar issues in the patch.

Will post a new version ASAP.

Thanks,
-- Dexuan


More information about the devel mailing list