[PATCH] staging: wilc1000: fix return value check in wlan_initialize_threads()

Julian Calaby julian.calaby at gmail.com
Thu Jun 23 01:33:17 UTC 2016


Hi All,

On Sat, Jun 18, 2016 at 3:34 AM,  <weiyj_lk at 163.com> wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> In case of error, the function kthread_run() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

The return value of wlan_initialize_threads() is only checked to be
non-zero, so this looks right to me.

Reviewed-by: Julian Calaby <julian.calaby at gmail.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby at gmail.com
Profile: http://www.google.com/profiles/julian.calaby/


More information about the devel mailing list