[PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with completion

Larry Finger Larry.Finger at lwfinger.net
Sun Jun 5 16:31:54 UTC 2016


On 06/03/2016 04:59 AM, Binoy Jayan wrote:
> The semaphore 'cmd_queue_sema' is used as completion,
> so convert it to struct completion.
>
> Signed-off-by: Binoy Jayan <binoy.jayan at linaro.org>

The subject for this patch has a misplaced "i" at the beginning courtesy of vi.

One other point, it is customary to start the patch subject with "staging: 
rtl8188eu: ..." for drivers in staging. I also prefer using r8188eu rather than 
rtl8188eu as the former is the actual name of the driver, but either will work.

I have tested all 4 of these patches with no problems, thus

Acked-by: Larry Finger <Larry.Finger at lwfinger.net>

As you may have noted, my testing of the modified driver has resulted in some 
additional fixes for various problems including a system panic caused by an 
ill-advised and untested change.

Larry



More information about the devel mailing list