[PATCH 33/33] Staging: android: ion: ion.c: Compression of lines for
joe at perches.com
Sat Jul 30 10:58:19 UTC 2016
On Sat, 2016-07-30 at 02:54 -0700, Nadim almas wrote:
> This patch compresses two lines in to a single line in file rtw_android.c
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
> It is done using script Coccinelle. And coccinelle uses following semantic
> patch for this compression function:
> expression e, ret;
> -ret =
> -return ret;
> Signed-off-by: Nadim Almas <nadim.902 at gmail.com>
> drivers/staging/android/ion/ion.c | 8 +++-----
> 1 files changed, 2 insertions(+), 4 deletions(-)
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
> return -ENODEV;
> - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
> - return ret;
> + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
How unfortunate you didn't heed the advice given..
I'll bet you didn't compile this.
More information about the devel