[PATCH 0/2 RFC] staging: ks7010: fix sparse warnings
Nicholas Mc Guire
hofrat at osadl.org
Wed Jul 27 12:23:35 UTC 2016
Two proposed fixes for sparse warnings
drivers/staging/ks7010/ks_wlan_net.c:3392:6: warning: symbol 'send_packet_complete'
was not declared. Should it be static?
looking at how it is used I guess it should not be static but
the extern declaration moved into ks_wlan.h
but all the functions declared extern there seem to be named ks_wlan_*,
indicating the layering of the interface, so I was unsure if that
should not also be renamed rather than just the extern moved.
drivers/staging/ks7010/ks_wlan_net.c:3525:5: warning: symbol 'ks_wlan_reset'
not declared. Should it be static?
that function is unused and it is doing nothing. Further the use of
ks_wlan_reset type functions seem uncommon anyway the only one I was
able to locate that is kind of a comparable functions was:
So I guess it really should just be dropped.
More information about the devel