staging: wilc1000: Reduce scope for a few variables in mac_ioctl()

SF Markus Elfring elfring at users.sourceforge.net
Tue Jul 26 06:25:54 UTC 2016


>> -			if (strncasecmp(buff, "RSSI", length) == 0) {
>> +			if (strncasecmp(buff, "RSSI", 0) == 0) {
>> +				s8 rssi;
>> +
> 
> Um, please think a second about if it makes any sense at all to compare 
> zero chars of two strings.

Under which circumstances should the variable "length" contain an other
value than zero?

How can this open issue be fixed better?

Regards,
Markus


More information about the devel mailing list