[PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.
Luis de Bethencourt
luisbg at osg.samsung.com
Fri Jul 8 18:17:41 UTC 2016
On 05/07/16 12:33, Samuele Baisi wrote:
> Removed a blankline after an opening bracket.
>
> Signed-off-by: Samuele Baisi <ciccio87 at gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..ae39663 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
> int j;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> -
> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
> if (!gdm)
> return -ENOMEM;
>
Patch applies cleanly and removes the checkpath issue.
Acked-by: Luis de Bethencourt <luisbg at osg.samsung.com>
Samuele,
It is a good idea to include the issue you are solving in the commit
message, in this case it would be:
Removed a blankline after an opening bracket.
CHECK: Blank lines aren't necessary after an open brace '{'
#228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
+ for (i = 0; i < TTY_MAX_COUNT; i++) {
+
Signed-off-by:
---
Thanks :)
Luis
More information about the devel
mailing list