[PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

Jes Sorensen Jes.Sorensen at redhat.com
Sun Jan 31 14:36:22 UTC 2016


Rakhi Sharma <rakhish1994 at gmail.com> writes:
> Fixed the space and brace coding style error.
> ERROR: space required before that '='
> ERROR: that open brace { should be on the previous line.
>
> Signed-off-by: Rakhi Sharma <rakhish1994 at gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> index 3b0d782..0c933e4 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> @@ -65,8 +65,8 @@ static u8 WIFI_OFDMRATES[] = {
>  
>  int rtw_get_bit_value_from_ieee_value23a(u8 val)
>  {
> -	unsigned char dot11_rate_table[] =
> -			{2, 4, 11, 22, 12, 18, 24, 36, 48, 72, 96, 108, 0};
> +	unsigned char dot11_rate_table[] = {
> +		2, 4, 11, 22, 12, 18, 24, 36, 48, 72, 96, 108, 0};
>  
>  	int i = 0;

This is a great example of checkpatch doing the wrong thing. What you
did here was to make the code uglier rather than better.

NACK

Jes


More information about the devel mailing list