[PATCH] staging: rtl8723au: Fixes unnecessary return warning

Jes Sorensen Jes.Sorensen at redhat.com
Fri Jan 29 18:00:40 UTC 2016


Bhaktipriya Shridhar <bhaktipriya96 at gmail.com> writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96 at gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index d28f29a..e8a16b9 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da)
>
>  	dump_mgntframe23a(padapter, pmgntframe);
>
> -	return;
>  }

If you insist on pushing this rather unncessary change, please do it
properly, and remove the blank line before the return statement as well.

Jes


More information about the devel mailing list