[PATCH 13/13] staging: wilc1000: fixes variable dereferenced before check

Glen Lee glen.lee at atmel.com
Wed Jan 27 02:50:37 UTC 2016


From: Leo Kim <leo.kim at atmel.com>

This patch fixes the warning reported by smatch.
 - wilc_wlan_get_firmware() warn: variable dereferenced before check 'vif'
 - wilc_set_multicast_list() warn: variable dereferenced before check 'dev'

Just delete them and no need add null check since they are net_device from
ndo_set_rx_mode of net_device_ops and vif of netdev_priv.

Signed-off-by: Leo Kim <leo.kim at atmel.com>
Signed-off-by: Glen Lee <glen.lee at atmel.com>
---
 drivers/staging/wilc1000/linux_wlan.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 9ca33536..22a2f98 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -397,9 +397,6 @@ int wilc_wlan_get_firmware(struct net_device *dev)
 
 	netdev_info(dev, "loading firmware %s\n", firmware);
 
-	if (!vif)
-		goto _fail_;
-
 	if (!(&vif->ndev->dev))
 		goto _fail_;
 
@@ -1017,9 +1014,6 @@ static void wilc_set_multicast_list(struct net_device *dev)
 	vif = netdev_priv(dev);
 	hif_drv = (struct host_if_drv *)priv->hif_drv;
 
-	if (!dev)
-		return;
-
 	if (dev->flags & IFF_PROMISC)
 		return;
 
-- 
1.9.1



More information about the devel mailing list