[PATCH] add fbtft ssd1325 controller support

Alexey Mednyy swexru at gmail.com
Tue Jan 26 15:31:44 UTC 2016



On 01/26/2016 05:09 PM, Dan Carpenter wrote:
> Same stuff.  Run checkpatch.pl.
>
>> +	gpio_set_value(par->gpio.dc, 1);
>> +	/* Write data */
>> +
>> +	ret =
>> +		par->fbtftops.write(par, par->txbuf.buf,
>> +				par->info->var.xres * par->info->var.yres / 2);
> Clean that line.
>
>> +static struct fbtft_display display = {
>> +	.regwidth = 8,
>> +	.width = WIDTH,
>> +	.height = HEIGHT,
>> +	.txbuflen = WIDTH * HEIGHT / 2,
> The other driver didn't have a txbuflen.  What does that do?  (I have
> barely looked at fbtft before so I don't know).
fbtft core creates 16bpp framebuffer, and default
txbuflen = display->width * display->height * bpp / 8;

so setting txbuflen saves some space in my case, I have 4bpp display.
>
> regards,
> dan carpenter
>



More information about the devel mailing list