[PATCH] add fbtft ssd1325 controller support

Dan Carpenter dan.carpenter at oracle.com
Tue Jan 26 14:09:28 UTC 2016


Same stuff.  Run checkpatch.pl.

> +	gpio_set_value(par->gpio.dc, 1);
> +	/* Write data */
> +
> +	ret =
> +		par->fbtftops.write(par, par->txbuf.buf,
> +				par->info->var.xres * par->info->var.yres / 2);

Clean that line.

> +static struct fbtft_display display = {
> +	.regwidth = 8,
> +	.width = WIDTH,
> +	.height = HEIGHT,
> +	.txbuflen = WIDTH * HEIGHT / 2,

The other driver didn't have a txbuflen.  What does that do?  (I have
barely looked at fbtft before so I don't know).

regards,
dan carpenter



More information about the devel mailing list