[PATCH] staging: most: add __iomem for io_base and registers

Hugo Camboulive hugo.camboulive at gmail.com
Sat Jan 2 21:59:42 UTC 2016


On Saturday 02 Jan 2016 20:33:23 (+0000), Al Viro wrote:
> On Sat, Jan 02, 2016 at 08:30:21PM +0000, Hugo Camboulive wrote:
> > This removes a few Sparse warnings.
> 
> > +	g.dim2 = (struct dim2_regs __iomem *)dim_base_address;
> 
> > -u8 dim_startup(void *dim_base_address, u32 mlb_clock);
> > +u8 dim_startup(void __iomem *dim_base_address, u32 mlb_clock);
> 
> Umm...  Why not have it take struct dim2_regs __iomem * as argument, and
> to hell with that cast?
Oh, right. I wasn't sure if the original void* was there for a reason. I'll send a v2.


More information about the devel mailing list