[PATCH v2 3/7] staging: unisys: cleanup goto in create_visor_device()

Dan Carpenter dan.carpenter at oracle.com
Tue Feb 23 20:36:52 UTC 2016


On Tue, Feb 23, 2016 at 12:05:22PM -0500, Benjamin Romer wrote:
> -away_register:
> +	away_unregister:
>  	device_unregister(&dev->device);
> -away:
> +
> +	away:
>  	put_device(&dev->device);

These cause checkpatch.pl errors.  Also "away" is too generic a name.
When I see "goto away;" I have no idea if it does everything or nothing
so I have to scroll down.  If it's call "away_put:" then that's clear to
me without scrolling down.

regards,
dan carpenter



More information about the devel mailing list