[PATCH V2 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages

Kim, Leo Leo.Kim at atmel.com
Fri Feb 19 01:47:02 UTC 2016


Hi Julian,

Yes, ongoing remove this function.
I will be removing this function for next patch.
Thank you in your advice.

 Thanks, BR
 Leo

-----Original Message-----
From: Julian Calaby [mailto:julian.calaby at gmail.com] 
Sent: Friday, February 19, 2016 9:41 AM
To: Kim, Leo <Leo.Kim at atmel.com>
Cc: Greg KH <gregkh at linuxfoundation.org>; devel at driverdev.osuosl.org; linux-wireless <linux-wireless at vger.kernel.org>; Cho, Tony <Tony.Cho at atmel.com>; Lee, Glen <Glen.Lee at atmel.com>; Shin, Austin <Austin.Shin at atmel.com>; Park, Chris <Chris.Park at atmel.com>; Abozaeid, Adham <Adham.Abozaeid at atmel.com>; Ferre, Nicolas <Nicolas.FERRE at atmel.com>
Subject: Re: [PATCH V2 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages

Hi Leo,

On Thu, Feb 18, 2016 at 10:30 PM, Leo Kim <leo.kim at atmel.com> wrote:
> From: Chris Park <chris.park at atmel.com>
>
> This patch removes unnecessary log messages.
>
> Signed-off-by: Chris Park <chris.park at atmel.com>
> Signed-off-by: Leo Kim <leo.kim at atmel.com>
> ---
>  drivers/staging/wilc1000/linux_wlan.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index a731b46..660bf63 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -226,7 +226,6 @@ static void deinit_irq(struct net_device *dev)
>
>  void wilc_dbg(u8 *buff)
>  {
> -       PRINT_D(INIT_DBG, "%d\n", *buff);
>  }

Are you sure this is right? If so, why not just remove this function entirely?

Thanks,

-- 
Julian Calaby

Email: julian.calaby at gmail.com
Profile: http://www.google.com/profiles/julian.calaby/


More information about the devel mailing list