[PATCH v3 4/4] Staging: gdm72xx: Remove BUG_ON

Greg Kroah-Hartman gregkh at linuxfoundation.org
Tue Feb 16 22:08:26 UTC 2016


On Wed, Feb 17, 2016 at 02:00:58AM +0530, Shraddha Barke wrote:
> Delete the BUG_ON check.
> 
> Signed-off-by: Shraddha Barke <shraddha.6596 at gmail.com>
> ---
> Changes in v3-
>  Deleted BUG_ON
> Changes in v2-
>  Nothing
> 
>  drivers/staging/gdm72xx/gdm_wimax.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c
> index 859880c..5db0b46 100644
> --- a/drivers/staging/gdm72xx/gdm_wimax.c
> +++ b/drivers/staging/gdm72xx/gdm_wimax.c
> @@ -100,8 +100,6 @@ static struct evt_entry *get_event_entry(void)
>  
>  static void put_event_entry(struct evt_entry *e)
>  {
> -	BUG_ON(!e);
> -
>  	list_add_tail(&e->list, &wm_event.freeq);

Sorry for the confusion, but I meant that put_event_entry() can be
removed, just replace the one place that calls it with the call to
list_add_tail() instead and then delete it entirely.

thanks,

greg k-h


More information about the devel mailing list